Detect ida.exe vs ida64.exe at runtime to support IDA 9.0+#167
Open
cmoski wants to merge 1 commit into
Open
Conversation
IDA 9.0 removed the separate ida64 binary and unified everything into a
single ida(.exe) executable. The compile-time `#if IDA_SDK_VERSION < 900`
switch previously used here is unreliable in practice: binexport_shared
is compiled without -DIDA_SDK_VERSION=..., so the macro defaults to 0
and the old ida64 branch is always taken. As a result, `bindiff --export`
shells out to a non-existent ida64.exe against IDA 9.x installs and
produces zero exports.
Replace the compile-time switch with a runtime check based on which
executable exists in options.ida_dir. This works across all supported
IDA versions:
- IDA 9.0+ (only ida.exe present): use ida.exe.
- IDA 7.x/8.x (both ida.exe and ida64.exe present): use ida64.exe
for 64-bit IDBs (.i64), ida.exe otherwise.
No public-API change; behavior is identical on older IDA installs.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDA 9.0 removed the separate ida64 binary and unified everything into a single ida(.exe) executable. The compile-time
#if IDA_SDK_VERSION < 900switch previously used here is unreliable in practice: binexport_shared is compiled without -DIDA_SDK_VERSION=..., so the macro defaults to 0 and the old ida64 branch is always taken. As a result,bindiff --exportshells out to a non-existent ida64.exe against IDA 9.x installs and produces zero exports.Replace the compile-time switch with a runtime check based on which executable exists in options.ida_dir. This works across all supported IDA versions:
No public-API change; behavior is identical on older IDA installs.